linux-kernel - Re: drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdX_uxbrkX=XF11WDBcuXjpQYWjjOzVzJ8ffj46oGw_JA@mail.gmail.com>
Date:   Fri, 9 Oct 2020 17:27:14 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Saravanan Sekar <sravanhome@...il.com>, kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: drivers/power/supply/mp2629_charger.c:522:9: warning: %d in
 format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

On Fri, Oct 9, 2020 at 4:23 PM kernel test robot <lkp@...el.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   549738f15da0e5a00275977623be199fbbf7df50
> commit: 3bc6d790c39dfc4539c36525e6bcb617abbae467 power: supply: Add support for mps mp2629 battery charger
> date:   4 months ago
> :::::: branch date: 12 hours ago
> :::::: commit date: 4 months ago
> compiler: sh4-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>

...

> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  514          unsigned int rval;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  515          int ret;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  516
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  517          ret = regmap_read(charger->regmap, MP2629_REG_IMPEDANCE_COMP, &rval);
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  518          if (ret)
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  519                  return ret;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  520
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  521          rval = (rval >> 4) * 10;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 @522          return sprintf(buf, "%d mohm\n", rval);
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26  523  }

Right, should be %u. Can LKP generate this type of patches?

-- 
With Best Regards,
Andy Shevchenko