linux-kernel - Re: [PATCH] net: intel: ice: Use uintptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e4c5d21c237afb5feb297b10d63550a15868ded.camel@intel.com>
Date:   Fri, 9 Oct 2020 16:35:35 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "shipujin.t@...il.com" <shipujin.t@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH] net: intel: ice: Use uintptr_t for casting data

On Fri, 2020-10-09 at 14:18 +0800, Pujin Shi wrote:
> Fix up a compiler error on 64bit architectures where pointers.
> 
> In file included from
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c:6:0:
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c: In function
> 'ice_free_flow_profs':
> drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from
> pointer to integer of different size [-Wpointer-to-int-cast]
>  #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
>                                  ^
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c:2882:9: note: in
> expansion of macro 'ICE_FLOW_ENTRY_HNDL'
>          ICE_FLOW_ENTRY_HNDL(e));
>          ^
> In file included from drivers/net/ethernet/intel/ice/ice_flow.c:5:0:
> drivers/net/ethernet/intel/ice/ice_flow.c: In function
> 'ice_flow_add_entry':
> drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from
> pointer to integer of different size [-Wpointer-to-int-cast]
>  #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
>                                  ^
> drivers/net/ethernet/intel/ice/ice_flow.c:946:13: note: in expansion
> of macro 'ICE_FLOW_ENTRY_HNDL'
>   *entry_h = ICE_FLOW_ENTRY_HNDL(e);
>              ^
> 
> 2 warnings generated
> 
> Signed-off-by: Pujin Shi <shipujin.t@...il.com>

Thanks for the patch Pujin, however, Bixuan Cui has already submitted a
patch to resolve this issue [1].

[1] 
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/85dcea48-8b82-d806-0026-e6b371e6a092@huawei.com/

Thanks,
Tony