linux-kernel - [tip: core/rcu] kvfree_rcu(): Fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 09 Oct 2020 17:01:21 -0000
From:   "tip-bot2 for kernel test robot" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        kernel test robot <lkp@...el.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        "Paul E. McKenney" <paulmck@...nel.org>, x86 <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: [tip: core/rcu] kvfree_rcu(): Fix ifnullfree.cocci warnings

The following commit has been merged into the core/rcu branch of tip:

Commit-ID:     849b9c5446ccb0c98c7b11c69f169d22777ab31b
Gitweb:        https://git.kernel.org/tip/849b9c5446ccb0c98c7b11c69f169d22777ab31b
Author:        kernel test robot <lkp@...el.com>
AuthorDate:    Sun, 27 Sep 2020 15:00:29 +02:00
Committer:     Paul E. McKenney <paulmck@...nel.org>
CommitterDate: Thu, 01 Oct 2020 09:07:24 -07:00

kvfree_rcu(): Fix ifnullfree.cocci warnings

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 16a6320addfc ("rcu/tree: Allocate a page when caller is preemptible")
Acked-by: Joel Fernandes (Google) <joel@...lfernandes.org>
Signed-off-by: kernel test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
---
 kernel/rcu/tree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 39ac930..09dfd03 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_struct *work)
 				bkvhead[i] = NULL;
 			krc_this_cpu_unlock(krcp, flags);
 
-			if (bkvhead[i])
-				kfree(bkvhead[i]);
+			kfree(bkvhead[i]);
 
 			cond_resched_tasks_rcu_qs();
 		}