linux-kernel - Re: [PATCH] power: supply: ltc2941: Fix ptr to enum cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 11 Oct 2020 01:30:57 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Iskren Chernev <iskren.chernev@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH] power: supply: ltc2941: Fix ptr to enum cast

Hi,

On Sat, Oct 10, 2020 at 09:55:26AM +0300, Iskren Chernev wrote:
> clang complains about casting pointers to smaller enum types.
> 
> Signed-off-by: Iskren Chernev <iskren.chernev@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ltc2941-battery-gauge.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/ltc2941-battery-gauge.c b/drivers/power/supply/ltc2941-battery-gauge.c
> index 30a9014b2f95e..10cd617516ec2 100644
> --- a/drivers/power/supply/ltc2941-battery-gauge.c
> +++ b/drivers/power/supply/ltc2941-battery-gauge.c
> @@ -473,7 +473,8 @@ static int ltc294x_i2c_probe(struct i2c_client *client,
>  
>  	np = of_node_get(client->dev.of_node);
>  
> -	info->id = (enum ltc294x_id)of_device_get_match_data(&client->dev);
> +	info->id = (enum ltc294x_id) (uintptr_t) of_device_get_match_data(
> +							&client->dev);
>  	info->supply_desc.name = np->name;
>  
>  	/* r_sense can be negative, when sense+ is connected to the battery
> 
> base-commit: 411643e949f4e616f758e2c6079f333b0e704c49
> -- 
> 2.28.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)