linux-kernel - Re: [PATCH] mm: memcontrol: eliminate redundant check in __mem_cgroup_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 10 Oct 2020 01:58:23 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Michal Hocko <mhocko@...e.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "hannes@...xchg.org" <hannes@...xchg.org>,
        "vdavydov.dev@...il.com" <vdavydov.dev@...il.com>,
        "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: eliminate redundant check in
 __mem_cgroup_insert_exceeded()

Michal Hocko <mhocko@...e.com> wrote:
> On Fri 09-10-20 09:51:04, Miaohe Lin wrote:
>> The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly 
>> the else case of mz->usage_in_excess < mz_node->usage_in_excess. So we 
>> could replace else if (mz->usage_in_excess >= 
>> mz_node->usage_in_excess) with else equally.
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>
>Acked-by: Michal Hocko <mhocko@...e.com>
>
>I believe this is a result of a very unreadable code. Resp. the comment makes it hard to follow. It would be slightly better to simply drop the comment which doesn't really explain much IMHO.
>

Agree. Will do it in v2. Many thanks.