linux-kernel - [tip: irq/core] irqchip/ti-sci-inta: Fix unsigned comparison to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 11 Oct 2020 17:57:45 -0000
From:   "tip-bot2 for YueHaibing" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     YueHaibing <yuehaibing@...wei.com>, Marc Zyngier <maz@...nel.org>,
        Lokesh Vutla <lokeshvutla@...com>, x86 <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: [tip: irq/core] irqchip/ti-sci-inta: Fix unsigned comparison to zero

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Gitweb:        https://git.kernel.org/tip/4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Author:        YueHaibing <yuehaibing@...wei.com>
AuthorDate:    Wed, 26 Aug 2020 11:54:30 +08:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Sun, 13 Sep 2020 15:30:00 +01:00

irqchip/ti-sci-inta: Fix unsigned comparison to zero

ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.

Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Acked-by: Lokesh Vutla <lokeshvutla@...com>
Link: https://lore.kernel.org/r/20200826035430.21060-1-yuehaibing@huawei.com
---
 drivers/irqchip/irq-ti-sci-inta.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e9760..05bf94b 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
 	struct irq_fwspec parent_fwspec;
 	struct device_node *parent_node;
 	unsigned int parent_virq;
-	u16 vint_id, p_hwirq;
-	int ret;
+	int p_hwirq, ret;
+	u16 vint_id;
 
 	vint_id = ti_sci_get_free_resource(inta->vint);
 	if (vint_id == TI_SCI_RESOURCE_NULL)