linux-kernel - Re: git grep/sed to standardize "/* SPDX-License-Identifier: <license>"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a43a8eefcd9ab82a5e29beb7b33491df24a048a.camel@perches.com>
Date:   Sun, 11 Oct 2020 13:29:38 -0700
From:   Joe Perches <joe@...ches.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Jiri Kosina <trivial@...nel.org>
Subject: Re: git grep/sed to standardize "/* SPDX-License-Identifier:
 <license>"

On Sun, 2020-10-11 at 11:47 -0700, Joe Perches wrote:
> On Sun, 2020-10-11 at 11:42 -0700, Linus Torvalds wrote:
> > On Tue, Oct 6, 2020 at 4:13 PM Joe Perches <joe@...ches.com> wrote:
> > > Almost all source files in the kernel use a standardized SPDX header
> > > at line 1 with a comment /* initiator and terminator */:
> > > 
> > > /* SPDX-License-Identifier: <license> */
> > > 
> > > $ git grep -PHn '^/\* SPDX-License-Identifier:.*\*/\s*$' | \
> > >   wc -l
> > > 17847
> > 
> > That grep pattern makes zero sense.
> > 
> > Why would */ be special at all? It isn't.
> > 
> >   $ git grep SPDX-License-Identifier: | wc -l
> >   52418
> > 
> > and a *LOT* of those are shell scripts and use "#", or are C sources
> > and use "//" etc.
> > 
> > So your "standardization" is completely pointless. Anybody who expects
> > that pattern just doing something fundamentally wrong, because the
> > pattern you want to standardize around is simply not valid.

btw:

The script would merely change these c90 comments to use the style
mandated by/proposed in Documentation/process/license-rules.rst