linux-kernel - Re: [PATCH RESEND] drm/aspeed: fix Kconfig warning & subsequent build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACPK8Xej8SoJxrJBL2NB2PnGwjFQ8=oWsfALv2g2r7HxxP9xZQ@mail.gmail.com>
Date:   Mon, 12 Oct 2020 04:38:56 +0000
From:   Joel Stanley <joel@....id.au>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Andrew Jeffery <andrew@...id.au>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Michal Simek <monstr@...str.eu>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...ux.ibm.com>, linux-mm@...ck.org,
        linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        David Airlie <airlied@...ux.ie>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH RESEND] drm/aspeed: fix Kconfig warning & subsequent build errors

On Sun, 11 Oct 2020 at 23:01, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> kernel test robot reported build errors (undefined references)
> that didn't make much sense. After reproducing them, there is also
> a Kconfig warning that is the root cause of the build errors, so
> fix that Kconfig problem.
>
> Fixes this Kconfig warning:
> WARNING: unmet direct dependencies detected for CMA
>   Depends on [n]: MMU [=n]
>   Selected by [m]:
>   - DRM_ASPEED_GFX [=m] && HAS_IOMEM [=y] && DRM [=m] && OF [=y] && (COMPILE_TEST [=y] || ARCH_ASPEED) && HAVE_DMA_CONTIGUOUS [=y]
>
> and these dependent build errors:
> (.text+0x10c8c): undefined reference to `start_isolate_page_range'
> microblaze-linux-ld: (.text+0x10f14): undefined reference to `test_pages_isolated'
> microblaze-linux-ld: (.text+0x10fd0): undefined reference to `undo_isolate_page_range'
>
> Fixes: 76356a966e33 ("drm: aspeed: Clean up Kconfig options")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Joel Stanley <joel@....id.au>
> Cc: Andrew Jeffery <andrew@...id.au>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Mike Rapoport <rppt@...ux.ibm.com>
> Cc: linux-mm@...ck.org
> Cc: linux-aspeed@...ts.ozlabs.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> ---
> First sent on 2020-09-07.
> Feel free to fix the Kconfig warning some other way...

Reviewed-by: Joel Stanley <joel@....id.au>

Thanks Randy. Sorry for missing it the first time around. I'll merge
this into drm-misc-next.

Cheers,

Joel



>
>  drivers/gpu/drm/aspeed/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20201009.orig/drivers/gpu/drm/aspeed/Kconfig
> +++ linux-next-20201009/drivers/gpu/drm/aspeed/Kconfig
> @@ -3,6 +3,7 @@ config DRM_ASPEED_GFX
>         tristate "ASPEED BMC Display Controller"
>         depends on DRM && OF
>         depends on (COMPILE_TEST || ARCH_ASPEED)
> +       depends on MMU
>         select DRM_KMS_HELPER
>         select DRM_KMS_CMA_HELPER
>         select DMA_CMA if HAVE_DMA_CONTIGUOUS