linux-kernel - Re: [PATCH] nfsd: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201012141938.GC26571@fieldses.org>
Date:   Mon, 12 Oct 2020 10:19:38 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     trix@...hat.com
Cc:     chuck.lever@...cle.com, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: remove unneeded break

On Sun, Oct 11, 2020 at 08:51:55AM -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Because every path through nfs4_find_file()'s
> switch does an explicit return, the break is not needed.

OK, applying.--b.

> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  fs/nfsd/nfs4state.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c09a2a4281ec..741f64672d96 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
>  			return find_readable_file(s->sc_file);
>  		else
>  			return find_writeable_file(s->sc_file);
> -		break;
>  	}
>  
>  	return NULL;
> -- 
> 2.18.1