linux-kernel - [PATCH] checkpatch: improve EXECUTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20201012151628.1234094-1-ujjwalkumar0501@gmail.com>
Date:   Mon, 12 Oct 2020 20:46:30 +0530
From:   Ujjwal Kumar <ujjwalkumar0501@...il.com>
To:     Joe Perches <joe@...ches.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Ujjwal Kumar <ujjwalkumar0501@...il.com>
Subject: [PATCH] checkpatch: improve EXECUTE_PERMISSIONS tests

1. Use group capture regexp for file mode test to improve code
   readability.

2. The 'scripts/' directory test on filenames can be excluded
   as it has become obsolete because there are many source
   files that are not scripts in this directory and its
   subdirectories.

3. Replace unnecessary group capture regexp with non-capturing
   group.

Suggested-by: Joe Perches <joe@...ches.com>
Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@...il.com>
---
 scripts/checkpatch.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index fab38b493cef..aa84999917b5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2678,10 +2678,11 @@ sub process {
 		}

 # Check for incorrect file permissions
-		if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
+		if ($line =~ /^new (?:file )?mode (\d+)$/) {
+			my $mode = substr($1, -3);
 			my $permhere = $here . "FILE: $realfile\n";
-			if ($realfile !~ m@...ipts/@ &&
-			    $realfile !~ /\.(py|pl|awk|sh)$/) {
+			if ($mode =~ /[1357]/ &&
+			    $realfile !~ /\.(?:py|pl|awk|sh)$/) {
 				ERROR("EXECUTE_PERMISSIONS",
 				      "do not set execute permissions for source files\n" . $permhere);
 			}

base-commit: d67bc7812221606e1886620a357b13f906814af7
--
2.26.2