linux-kernel - Re: [PATCH v3 0/2] nvmem: skip nodes with compatibles other than "nvmem-cell"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f03ecee7-c4b6-7a59-7ab8-42c5dfcaffc4@pengutronix.de>
Date:   Mon, 12 Oct 2020 17:36:01 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Rob Herring <robh@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        ceggers@...i.de, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 0/2] nvmem: skip nodes with compatibles other than
 "nvmem-cell"

Hello Rob,
Hello Srini,

On 5/12/20 4:18 PM, Rob Herring wrote:
> On Tue, Apr 28, 2020 at 01:18:25PM +0200, Ahmad Fatoum wrote:
>> The nvmem cell binding applies to all objects which match "^.*@[0-9a-f]+$",
>> without taking a compatible into account. This precludes extension of e.g.
>> eeprom nodes by any child nodes other than nvmem. Consider following example:
>>
>> 	eeprom@0 {
>> 		reg = <0 64>;
>> 		#address-cells = <1>;
>> 		#size-cells = <1>;
>>
>> 		partitions {
>> 			compatible = "fixed-partitions";
>> 			#address-cells = <1>;
>> 			#size-cells = <1>;
>> 			bits = <64 64 64>; /* to verify it's skipped */
>>
>> 			part@0 {
>> 				reg = <0x00 16>;
>> 			};
>> 		};
>>
>> 		no-cell@10 {
>> 			compatible = "not-nvmem-cell";
>> 			reg = <0x10 4>;
>> 			bits = <64 64 64>; /* to verify it's skipped */
>> 		};
>>
>> 		cell-old@14 {
>> 			reg = <0x14 0x2>;
>> 		};
>>
>> 		cell-new@16 {
>> 			compatible = "nvmem-cell";
>> 			reg = <0x16 4>;
>> 		};
>> 	};
>>
>> Without this series, the NVMEM driver interprets all direct children of eeprom@0
>> as NVMEM cells and driver probe fails, because the partitions node lacks a reg
>> property, e.g.:
>>
>>   nvmem 0-00000: nvmem: invalid reg on /eeprom@0
>>
>> Running dtbs_check on the snippet will skip partitions (it doesn't match above
>> regex), but will flag no-cell@10 and cell-new@16 as invalid.
>>
>> With this series applied, the driver will skip partitions and no-cell@10,
>> because they have a compatible but it's not "nvmem-cell".
> 
> Because you have to support no compatible (forever), there's no point 
> adding this compatible.

IMO nvmem cells should have had a compatible since the beginning and I figured
better late than never.

>> Both cell-old@14 and cell-new@16 will be interpreted as cells.
>>
>> Likewise, running dtbs_check on the snippet will skip partitions (compatible
>> doesn't match and regex doesn't either) and no-cell@10, but accept the other two.
>>
>> This series resolves an existing clash between this nvmem-cell binding and
>> the barebox bootloader binding that extends the fixed-partitions MTD
>> binding to EEPROMs[1]. It's also a building block for getting nvmem cells and
>> partitions in MTD devices to co-exist in the same device tree node[2].
> 
> This violates having multiple nodes at the same address because you are 
> independently overlaying partitions and nvmem cells on same address 
> ranges. It also seems seems pretty fragile if you want to update 
> partitions.
> 
> I think instead, nvmem cells should be contained within a partition. 
> The partition should then have a compatible to indicate it contains 
> nvmem cells.

I thought I had understood what needs to be done, but now that I finally have time
to do it, I see that this only solves the second issue "extending the NVMEM binding
to nodes that already have other child nodes, e.g., MTD and its partitions".

The first issue: "future extension of e.g. eeprom nodes by any child nodes other than
nvmem cells" isn't solved by having a containing partition.


My issue is that the bootloader fixes up a partitions { compatible = "fixed-partitions"; }
child node into the kernel device tree. The NVMEM core driver tries to parse all eeprom child
nodes as cells and will make the driver probe of the EEPROM fail, because it can't parse that
fixed-partitions node as a nvmem cell.

To allow for co-existence of NVMEM cells and other subnodes, would following patch be
acceptable to you and Srini?

---------------------------------------- 8< --------------------------------------
--- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
@@ -45,7 +45,15 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
-
+    if:
+      not:
+        properties:
+          compatible:
+    then:
+      $ref: "#/definitions/nvmem-cell"
+
+definitions:
+  nvmem-cell:
     properties:
       reg:
         maxItems: 1