linux-kernel - Re: [PATCH] kthread: Add kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 11:37:48 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Rob Clark <robdclark@...omium.org>
Cc:     Rob Clark <robdclark@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Phil Auld <pauld@...hat.com>,
        Valentin Schneider <valentin.schneider@....com>,
        Thara Gopinath <thara.gopinath@...aro.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Vincent Donnefort <vincent.donnefort@....com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jens Axboe <axboe@...nel.dk>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Ilias Stamatis <stamatis.iliass@...il.com>,
        Liang Chen <cl@...k-chips.com>,
        Ben Dooks <ben.dooks@...ethink.co.uk>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        "J. Bruce Fields" <bfields@...hat.com>
Subject: Re: [PATCH] kthread: Add kthread_work tracepoints

On Mon, 12 Oct 2020 08:14:50 -0700
Rob Clark <robdclark@...omium.org> wrote:

> > DEFINE_EVENT(sched_kthread_work_execute_template, sched_kthread_work_execute_start,
> >         TP_PROTO(struct kthread_work *work),
> >         TP_ARGS(work));
> >
> > DEFINE_EVENT(sched_kthread_work_execute_template, sched_kthread_work_execute_end,
> >         TP_PROTO(struct kthread_work *work),
> >         TP_ARGS(work));
> >
> > As events are cheap, classes are expensive (size wise), and a TRACE_EVENT()
> > is really just a CLASS and EVENT for a single instance.  
> 
> I think we cannot quite do this, because we should not rely on being

Ah I missed seeing that one used work->func and the other passed in the
function.

> able to dereference work after it finishes.  Although I suppose I
> could just define it to explicitly pass the fxn ptr to both
> tracepoints..

But yes, I would rather see that. It could save up to 5K in text and data.

-- Steve