linux-kernel - Re: [PATCH v9 6/6] memory: dfl-emif: add the DFL EMIF private feature driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 18:40:46 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Xu Yilun <yilun.xu@...el.com>
Cc:     mdf@...nel.org, linux-fpga@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        gregkh@...uxfoundation.org, trix@...hat.com, lgoncalv@...hat.com,
        hao.wu@...el.com, Russ Weight <russell.h.weight@...el.com>
Subject: Re: [PATCH v9 6/6] memory: dfl-emif: add the DFL EMIF private feature driver

On Sat, 10 Oct 2020 at 09:15, Xu Yilun <yilun.xu@...el.com> wrote:
>
> This driver is for the EMIF private feature implemented under FPGA
> Device Feature List (DFL) framework. It is used to expose memory
> interface status information as well as memory clearing control.
>
> The purpose of memory clearing block is to zero out all private memory
> when FPGA is to be reprogrammed. This gives users a reliable method to
> prevent potential data leakage.
>
> Signed-off-by: Xu Yilun <yilun.xu@...el.com>
> Signed-off-by: Russ Weight <russell.h.weight@...el.com>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> v2: Adjust the position of this driver in Kconfig.
>     Improves the name of the Kconfig option.
>     Change the include dfl-bus.h to dfl.h, cause the previous patchset
>      renames the file.
>     Some minor fixes and comment improvement.
> v3: Adjust the position of the driver in Makefile.
> v9: Add static prefix for emif attributes macro
>     Update the kernel version of the sysfs interfaces in Doc.
> ---
>  .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
>  drivers/memory/Kconfig                             |   9 +
>  drivers/memory/Makefile                            |   2 +
>  drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
>  4 files changed, 243 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
>  create mode 100644 drivers/memory/dfl-emif.c
>

I am confused now. This was already taken by Moritz, wasn't it? And
the dependencies were already taken, weren't they? Previously it was
depending on "Modularization of DFL private feature drivers" and "add
dfl bus support to MODULE_DEVICE_TABLE()"... now this is here so did
the dependencies change? What is the reason to include this patch
here?

My ack was for the purpose of taking it via Moritz tree, because of
the dependencies. If this is not the case, then probably better to
take it via memory controllers tree to avoid any conflicts (it's not a
small change).

Best regards,
Krzysztof