[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f3a1cd68a3f8f83e9e78a6ac1e5b74ceccbdc8be.camel@klomp.org>
Date: Mon, 12 Oct 2020 21:12:44 +0200
From: Mark Wielaard <mark@...mp.org>
To: Nick Desaulniers <ndesaulniers@...gle.com>,
Ian Rogers <irogers@...gle.com>
Cc: Andi Kleen <andi@...stfloor.org>, linux-toolchains@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>,
Stephane Eranian <eranian@...gle.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
"Phillips, Kim" <kim.phillips@....com>,
Mark Rutland <mark.rutland@....com>,
Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] Only add -fno-var-tracking-assignments workaround for
old GCC versions.
Hi,
On Mon, 2020-10-12 at 11:59 -0700, Nick Desaulniers wrote:
> On Sat, Oct 10, 2020 at 3:57 PM Ian Rogers <irogers@...gle.com>
> wrote:
> > On Sat, Oct 10, 2020 at 3:08 PM Mark Wielaard <mark@...mp.org>
> > wrote:
> > > -DEBUG_CFLAGS := $(call cc-option, -fno-var-tracking-
> > > assignments)
> > > +# Workaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61801
> > > +# for old versions of GCC.
> > > +DEBUG_CFLAGS := $(call cc-ifversion, -lt, 0500, $(call cc-
> > > option, -fno-var-tracking-assignments))
>
> Should this be wrapped in: `ifdef CONFIG_CC_IS_GCC`/`endif`?
I don't think so. It wasn't before. And call cc-option makes sure to
only add the flag if the compiler supports it (clang doesn't and it
also has a much higher version).
Cheers,
Mark
Powered by blists - more mailing lists