linux-kernel - Re: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2029402034.189005.1602530239737.JavaMail.zimbra@nod.at>
Date:   Mon, 12 Oct 2020 21:17:19 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: hyperbus: Fix build failure when only
 RPCIF_HYPERBUS is enabled

----- Ursprüngliche Mail -----
> Von: "Vignesh Raghavendra" <vigneshr@...com>
> An: "Vignesh Raghavendra" <vigneshr@...com>, "Miquel Raynal" <miquel.raynal@...tlin.com>, "richard" <richard@....at>
> CC: "Sergei Shtylyov" <sergei.shtylyov@...il.com>, "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>
> Gesendet: Montag, 12. Oktober 2020 09:09:58
> Betreff: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled

> commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
> is because driver needs functions RENESAS_RPCIF which is only buildable
> for CONFIG_ARCH_RENESAS.
> 
> Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
> This ensures driver can be built only when RENESAS_RPCIF is also
> selected.
> 
> [1]:
> rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
> rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
> [...]
> 
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> Reported-by: Richard Weinberger <richard@....at>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> ---
> 
> Based on mtd/next
> 
> Richard,
> 
> Could you please pull this into mtd/next?

Applied! :-)

Thanks,
//richard