linux-kernel - Re: [PATCH 2/2] dt-bindings: arm: sunxi: Fix Orange Pi Zero bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201012200324.yua77qwqbgfh42z7@core.my.home>
Date:   Mon, 12 Oct 2020 22:03:24 +0200
From:   Ondřej Jirman <megous@...ous.com>
To:     Michal Suchánek <msuchanek@...e.de>
Cc:     Maxime Ripard <maxime@...no.tech>,
        linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Corentin Labbe <clabbe@...libre.com>,
        Stefan Mavrodiev <stefan@...mex.com>,
        Icenowy Zheng <icenowy@...c.io>,
        Georgii Staroselskii <georgii.staroselskii@...id.com>,
        Bastian Germann <bage@...utronix.de>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: arm: sunxi: Fix Orange Pi Zero bindings

Hello Michal,

On Mon, Oct 12, 2020 at 08:04:02PM +0200, Michal Suchánek wrote:
> On Mon, Oct 12, 2020 at 04:47:53PM +0200, Maxime Ripard wrote:
> > On Thu, Oct 08, 2020 at 08:40:06PM +0200, Michal Suchanek wrote:
> > > There are two models of Orange Pi zero which are confusingly marketed
> > > under the same name. Old model comes without a flash memory and current
> > > model does have a flash memory. Add bindings for each model.
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> > 
> > Unfortunately, changing a compatible or a DT filename is not an option
> 
> So how do you handle the situation when you find out that there are two
> different devices marketed under the same name?
> 
> Surely the device tree is labaled by the device name but now you need
> two device trees that describe the two devices.

You can for example make the new DT name *-flash.dts, instead
of changing the name of existing DT to *-noflash.dts. Or if there's
a version number on the PCB that differs from the older variant,
use that version to differentiate the newer board DT.

regards,
	o.

> Thanks
> 
> Michal