linux-kernel - Re: [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4354fb15-9aa0-0957-eea8-89a930774d40@sandeen.net>
Date:   Mon, 12 Oct 2020 16:23:32 -0500
From:   Eric Sandeen <sandeen@...deen.net>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        Pavel Machek <pavel@....cz>, xfs <linux-xfs@...r.kernel.org>
Cc:     kernel list <linux-kernel@...r.kernel.org>, dchinner@...hat.com,
        sandeen@...hat.com
Subject: Re: [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when
 XFS_FS=n

On 10/12/20 4:11 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Pavel Machek complained that the question about supporting deprecated
> XFS v4 comes up even when XFS is disabled.  This clearly makes no sense,
> so fix Kconfig.
> 
> Reported-by: Pavel Machek <pavel@....cz>
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

> ---
>  fs/xfs/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 5422227e9e93..9fac5ea8d0e4 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -24,6 +24,7 @@ config XFS_FS
>  
>  config XFS_SUPPORT_V4
>  	bool "Support deprecated V4 (crc=0) format"
> +	depends on XFS_FS
>  	default y
>  	help
>  	  The V4 filesystem format lacks certain features that are supported
>