linux-kernel - Re: [PATCH] perf c2c: Update usage for showing memory events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 11:13:48 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf c2c: Update usage for showing memory events

On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> show the default events used"), "perf c2c" tool can show the memory
> events properly, it's no reason to still suggest user to use the
> command "perf mem record -e list" for showing events.
> 
> This patch updates the usage for showing memory events with command
> "perf c2c record -e list".
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> ---
>  tools/perf/builtin-c2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 5938b100eaf4..57bb6cce43e3 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
>  	bool event_set = false;
>  	struct option options[] = {
>  	OPT_CALLBACK('e', "event", &event_set, "event",
> -		     "event selector. Use 'perf mem record -e list' to list available events",
> +		     "event selector. Use 'perf c2c record -e list' to list available events",
>  		     parse_record_events),
>  	OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
>  	OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
> -- 
> 2.17.1
>