linux-kernel - Re: [PATCH] sched/features: Fix !CONFIG_JUMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jhj8scbenhx.mognet@arm.com>
Date:   Mon, 12 Oct 2020 11:40:10 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Juri Lelli <juri.lelli@...hat.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, bristot@...hat.com,
        patrick.bellasi@...bug.net, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, chris.redpath@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de
Subject: Re: [PATCH] sched/features: Fix !CONFIG_JUMP_LABEL case


Hi,

On 12/10/20 06:39, Juri Lelli wrote:
> Commit 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> !CONFIG_SCHED_DEBUG builds") made sched features static for
> !CONFIG_SCHED_DEBUG configurations, but overlooked the CONFIG_
> SCHED_DEBUG enabled and !HAVE_JUMP_LABEL cases. For the latter, echoing
> changes to /sys/kernel/debug/sched_features has the nasty effect of
> effectively changing what sched_features reports, but without actually
> changing the scheduler behaviour (since different translation units get
> different sysctl_sched_features).
>
> Fix CONFIG_SCHED_DEBUG and !HAVE_JUMP_LABEL configurations by properly
> restructuring ifdefs.
>

That should be CONFIG_JUMP_LABEL, no? The HAVE stuff should've died with

  e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig")

> Fixes: 765cc3a4b224e ("sched/core: Optimize sched_feat() for !CONFIG_SCHED_DEBUG builds")
> Co-developed-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> Signed-off-by: Juri Lelli <juri.lelli@...hat.com>

With the aforementioned replacement (changelog AND diff):

Reviewed-by: Valentin Schneider <valentin.schneider@....com>