linux-kernel - Re: [PATCH v9 4/6] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 10:31:29 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     mdf@...nel.org, krzk@...nel.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, trix@...hat.com, lgoncalv@...hat.com,
        hao.wu@...el.com, yilun.xu@...el.com
Subject: Re: [PATCH v9 4/6] fpga: dfl: move dfl bus related APIs to
  include/linux/fpga/dfl.h

On Sun, Oct 11, 2020 at 04:45:22PM +0200, Greg KH wrote:
> On Sat, Oct 10, 2020 at 03:09:51PM +0800, Xu Yilun wrote:
> > Now the dfl drivers could be made as independent modules and put in
> > different folders according to their functionalities. In order for
> > scattered dfl device drivers to include dfl bus APIs, move the
> > dfl bus APIs to a new header file in the public folder.
> > 
> > [mdf@...nel.org: Fixed up MAINTAINERS entry merge]
> > Signed-off-by: Xu Yilun <yilun.xu@...el.com>
> > Reviewed-by: Tom Rix <trix@...hat.com>
> > Acked-by: Wu Hao <hao.wu@...el.com>
> > Signed-off-by: Moritz Fischer <mdf@...nel.org>
> > ---
> > v2: updated the MAINTAINERS under FPGA DFL DRIVERS
> >     improve the comments
> >     rename the dfl-bus.h to dfl.h
> > v3: rebase the patch for previous changes
> > v9: rebase the patch for bus name changes back to "dfl"
> > ---
> >  MAINTAINERS              |  1 +
> >  drivers/fpga/dfl.c       |  1 +
> >  drivers/fpga/dfl.h       | 72 ----------------------------------------
> >  include/linux/fpga/dfl.h | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
> 
> Why in the fpga directory?

OK, since the dfl could be independent to fpga, I think it could be put in include/linux.

Thanks,
Yilun

> 
> thanks,
> 
> greg k-h