linux-kernel - Re: [PATCH] gpu/drm/armada: fix unused parameter warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 13:14:30 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Bernard Zhao <bernard@...o.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re: [PATCH] gpu/drm/armada: fix unused parameter warning

On Mon, Oct 12, 2020 at 04:57:24AM -0700, Bernard Zhao wrote:
> Functions armada_drm_crtc_atomic_flush &
> armada_drm_crtc_atomic_enable don`t use the second parameter.
> So we may get warning like :
> warning: unused parameter ‘***’ [-Wunused-parameter].
> This change is to fix the compile warning with -Wunused-parameter.

Under what circumstances do we build the kernel with that warning
enabled?

> 
> Signed-off-by: Bernard Zhao <bernard@...o.com>
> ---
>  drivers/gpu/drm/armada/armada_crtc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c
> index 38dfaa46d306..fc8b922c3e44 100644
> --- a/drivers/gpu/drm/armada/armada_crtc.c
> +++ b/drivers/gpu/drm/armada/armada_crtc.c
> @@ -427,7 +427,7 @@ static int armada_drm_crtc_atomic_check(struct drm_crtc *crtc,
>  }
>  
>  static void armada_drm_crtc_atomic_begin(struct drm_crtc *crtc,
> -					 struct drm_crtc_state *old_crtc_state)
> +				struct drm_crtc_state __attribute__((unused)) *old_crtc_state)
>  {
>  	struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
>  
> @@ -441,7 +441,7 @@ static void armada_drm_crtc_atomic_begin(struct drm_crtc *crtc,
>  }
>  
>  static void armada_drm_crtc_atomic_flush(struct drm_crtc *crtc,
> -					 struct drm_crtc_state *old_crtc_state)
> +				struct drm_crtc_state __attribute__((unused)) *old_crtc_state)
>  {
>  	struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
>  
> -- 
> 2.28.0
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!