linux-kernel - Re: [PATCH V2 2/3] arm64: dts: imx8mn: Correct WDOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201012130510.GB6468@kozik-lap>
Date:   Mon, 12 Oct 2020 15:05:10 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     robh+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, aford173@...il.com,
        daniel.baluta@....com, shengjiu.wang@....com, peter.chen@....com,
        alifer.wsdm@...il.com, abel.vesa@....com, yibin.gong@....com,
        jun.li@....com, l.stach@...gutronix.de, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Linux-imx@....com
Subject: Re: [PATCH V2 2/3] arm64: dts: imx8mn: Correct WDOG_B pin
 configuration

On Mon, Oct 12, 2020 at 08:44:01PM +0800, Anson Huang wrote:
> Different revision of i.MX8MN EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MN boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
> Changes since V1:
> 	- Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof