linux-kernel - Re: [PATCH v1 04/29] virtio-mem: drop rc2 in virtio_mem_mb_plug_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Oct 2020 15:09:55 +0200
From:   Pankaj Gupta <pankaj.gupta.linux@...il.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>,
        virtualization@...ts.linux-foundation.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH v1 04/29] virtio-mem: drop rc2 in virtio_mem_mb_plug_and_add()

> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@...il.com>
> Signed-off-by: David Hildenbrand <david@...hat.com>
> ---
>  drivers/virtio/virtio_mem.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 78c2fbcddcf8..b3eebac7191f 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -1072,7 +1072,7 @@ static int virtio_mem_mb_plug_and_add(struct virtio_mem *vm,
>                                       uint64_t *nb_sb)
>  {
>         const int count = min_t(int, *nb_sb, vm->nb_sb_per_mb);
> -       int rc, rc2;
> +       int rc;
>
>         if (WARN_ON_ONCE(!count))
>                 return -EINVAL;
> @@ -1103,13 +1103,12 @@ static int virtio_mem_mb_plug_and_add(struct virtio_mem *vm,
>
>                 dev_err(&vm->vdev->dev,
>                         "adding memory block %lu failed with %d\n", mb_id, rc);
> -               rc2 = virtio_mem_mb_unplug_sb(vm, mb_id, 0, count);
>
>                 /*
>                  * TODO: Linux MM does not properly clean up yet in all cases
>                  * where adding of memory failed - especially on -ENOMEM.
>                  */
> -               if (rc2)
> +               if (virtio_mem_mb_unplug_sb(vm, mb_id, 0, count))
>                         new_state = VIRTIO_MEM_MB_STATE_PLUGGED;
>                 virtio_mem_mb_set_state(vm, mb_id, new_state);
>                 return rc;

Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@...il.com>