[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20201012025643.6883-1-jingxiangfeng@huawei.com>
Date: Mon, 12 Oct 2020 10:56:43 +0800
From: Jing Xiangfeng <jingxiangfeng@...wei.com>
To: <sre@...nel.org>, <gustavoars@...nel.org>, <pavel@....cz>
CC: <linux-kernel@...r.kernel.org>, <jingxiangfeng@...wei.com>
Subject: [PATCH] HSI: omap_ssi: Don't jump to free ID in ssi_add_controller()
In current code, it jumps to ida_simple_remove() when ida_simple_get()
failes to allocate an ID. Just return to fix it.
Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
---
drivers/hsi/controllers/omap_ssi_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index fa69b94debd9..7596dc164648 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -355,7 +355,7 @@ static int ssi_add_controller(struct hsi_controller *ssi,
err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);
if (err < 0)
- goto out_err;
+ return err;
ssi->id = err;
ssi->owner = THIS_MODULE;
--
2.17.1
Powered by blists - more mailing lists