linux-kernel - Re: [PATCH v3] arm64/mm: add fallback option to allocate virtually contiguous memory

Open Source and information security mailing list archives

Message-ID: <c61139c9-0949-e602-f880-9731eafc7a67@redhat.com>
Date:   Mon, 12 Oct 2020 13:54:40 +1100
From:   Gavin Shan <gshan@...hat.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        Sudarshan Rajagopalan <sudaraja@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Mark Rutland <mark.rutland@....com>, Will Deacon <will@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Steven Price <steven.price@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Logan Gunthorpe <logang@...tatee.com>
Subject: Re: [PATCH v3] arm64/mm: add fallback option to allocate virtually
 contiguous memory

On 10/6/20 2:36 PM, Anshuman Khandual wrote:
> On 10/02/2020 01:46 AM, Sudarshan Rajagopalan wrote:
>> When section mappings are enabled, we allocate vmemmap pages from physically
>> continuous memory of size PMD_SIZE using vmemmap_alloc_block_buf(). Section
>> mappings are good to reduce TLB pressure. But when system is highly fragmented
>> and memory blocks are being hot-added at runtime, its possible that such
>> physically continuous memory allocations can fail. Rather than failing the
>> memory hot-add procedure, add a fallback option to allocate vmemmap pages from
>> discontinuous pages using vmemmap_populate_basepages().
>>
>> Signed-off-by: Sudarshan Rajagopalan <sudaraja@...eaurora.org>
>> Cc: Catalin Marinas <catalin.marinas@....com>
>> Cc: Will Deacon <will@...nel.org>
>> Cc: Anshuman Khandual <anshuman.khandual@....com>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Logan Gunthorpe <logang@...tatee.com>
>> Cc: David Hildenbrand <david@...hat.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Steven Price <steven.price@....com>
>> ---
>>   arch/arm64/mm/mmu.c | 11 +++++++++--
>>   1 file changed, 9 insertions(+), 2 deletions(-)
>>

It looks good to me with Anshuman's comments fixed:

Reviewed-by: Gavin Shan <gshan@...hat.com>

>> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
>> index 75df62f..11f8639 100644
>> --- a/arch/arm64/mm/mmu.c
>> +++ b/arch/arm64/mm/mmu.c
>> @@ -1121,8 +1121,15 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
>>   			void *p = NULL;
>>   
>>   			p = vmemmap_alloc_block_buf(PMD_SIZE, node, altmap);
>> -			if (!p)
>> -				return -ENOMEM;
>> +			if (!p) {
>> +				/*
>> +				 * fallback allocating with virtually
>> +				 * contiguous memory for this section
>> +				 */
> 
> Mapping is always virtually contiguous with or without huge pages.
> Please drop this comment here, as it's obvious.
> 
>> +				if (vmemmap_populate_basepages(addr, next, node, NULL))
>> +					return -ENOMEM;
> 
> Please send in the 'altmap' instead of NULL for allocation from
> device memory if and when requested.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives