linux-kernel - Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201013065232.hdyjdkurkmowkf2f@beryllium.lan>
Date:   Tue, 13 Oct 2020 08:52:32 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     Nilesh Javali <njavali@...vell.com>, Arun Easi <aeasi@...vell.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion

On Tue, Oct 13, 2020 at 10:59:18AM +1100, Finn Thain wrote:
> 
> On Mon, 12 Oct 2020, Daniel Wagner wrote:
> 
> > When the fcport is about to be deleted we should return EBUSY instead
> > of ENODEV. Only for EBUSY the request will be requeued in a multipath
> > setup.
> > 
> > Also in case we have a valid qpair but the firmware has not yet
> > started return EBUSY to avoid dropping the request.
> > 
> > Signed-off-by: Daniel Wagner <dwagner@...e.de>
> > ---
> > 
> > v3: simplify test logic as suggested by Arun.
> 
> Not exactly a "simplification": there was a change of behaviour between v2 
> and v3. It seems the commit log no longer reflects the code.

How so? I am struggling to see how it could be a change in behavior. But
then I sometimes fail at simple logic ;)

v2 and v3 will return ENODEV if qpair or fcport are invalid and for
EBUSY one of the other condition needs be true. The difference between
v2 and v3 should only be the order how tests are executed. The outcome
should be the same.