linux-kernel - RE: [PATCH v3] usb: cdns3: Rids of duplicate error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM8PR04MB7300072DF781A5FD6FAA51DD8B040@AM8PR04MB7300.eurprd04.prod.outlook.com>
Date:   Tue, 13 Oct 2020 07:53:49 +0000
From:   Peter Chen <peter.chen@....com>
To:     Pawel Laszczak <pawell@...ence.com>,
        "balbi@...nel.org" <balbi@...nel.org>
CC:     "rogerq@...com" <rogerq@...com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kurahul@...ence.com" <kurahul@...ence.com>
Subject: RE: [PATCH v3] usb: cdns3: Rids of duplicate error message

 
> On failure, the platform_get_irq_byname prints an error message so, patch

typo, "message, so patch..." Otherwise:

Acked-by: Peter Chen <peter.chen@....com>

Peter

> removes error message related to this function from core.c file.
> 
> A change was suggested during reviewing CDNSP driver by Chunfeng Yun.
> 
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
> ---
> Changelog:
> v3
> - changed error condition checking for dev_irq.
> v2
> - simplified code as sugested by Roger Quadros.
> 
>  drivers/usb/cdns3/core.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index
> a0f73d4711ae..f2dedce3a40e 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -466,11 +466,8 @@ static int cdns3_probe(struct platform_device *pdev)
>  	cdns->xhci_res[1] = *res;
> 
>  	cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral");
> -	if (cdns->dev_irq == -EPROBE_DEFER)
> -		return cdns->dev_irq;
> -
>  	if (cdns->dev_irq < 0)
> -		dev_err(dev, "couldn't get peripheral irq\n");
> +		return cdns->dev_irq;
> 
>  	regs = devm_platform_ioremap_resource_byname(pdev, "dev");
>  	if (IS_ERR(regs))
> @@ -478,14 +475,9 @@ static int cdns3_probe(struct platform_device *pdev)
>  	cdns->dev_regs	= regs;
> 
>  	cdns->otg_irq = platform_get_irq_byname(pdev, "otg");
> -	if (cdns->otg_irq == -EPROBE_DEFER)
> +	if (cdns->otg_irq < 0)
>  		return cdns->otg_irq;
> 
> -	if (cdns->otg_irq < 0) {
> -		dev_err(dev, "couldn't get otg irq\n");
> -		return cdns->otg_irq;
> -	}
> -
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otg");
>  	if (!res) {
>  		dev_err(dev, "couldn't get otg resource\n");
> --
> 2.17.1