linux-kernel - Re: [PATCH v2] sched/features: Fix !CONFIG_JUMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201013104811.GE89256@localhost.localdomain>
Date:   Tue, 13 Oct 2020 12:48:11 +0200
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Patrick Bellasi <patrick.bellasi@...bug.net>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, bristot@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        chris.redpath@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, valentin.schneider@....com
Subject: Re: [PATCH v2] sched/features: Fix !CONFIG_JUMP_LABEL case

On 13/10/20 10:26, Patrick Bellasi wrote:
> 
> On Tue, Oct 13, 2020 at 07:31:14 +0200, Juri Lelli <juri.lelli@...hat.com> wrote...
> 
> > Commit 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> > !CONFIG_SCHED_DEBUG builds") made sched features static for
> > !CONFIG_SCHED_DEBUG configurations, but overlooked the CONFIG_
> > SCHED_DEBUG enabled and !CONFIG_JUMP_LABEL cases. For the latter echoing
> > changes to /sys/kernel/debug/sched_features has the nasty effect of
> > effectively changing what sched_features reports, but without actually
> > changing the scheduler behaviour (since different translation units get
> > different sysctl_sched_features).
> 
> Hops, yes, I think I missed to properly check that config :/
> Good spot!
> 
> > Fix CONFIG_SCHED_DEBUG and !CONFIG_JUMP_LABEL configurations by properly
> > restructuring ifdefs.
> >
> > Fixes: 765cc3a4b224e ("sched/core: Optimize sched_feat() for !CONFIG_SCHED_DEBUG builds")
> > Co-developed-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> > Signed-off-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> > Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
> 
> (did you get some wrong formatting for the changelog above?)

Hummm, what you mean?

I intended to follow

https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L566