linux-kernel - Re: [PATCH] thunderbolt: Add the missed ida_simple_remove() in ring_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Oct 2020 14:43:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     andreas.noever@...il.com, michael.jamet@...el.com,
        mika.westerberg@...ux.intel.com, YehezkelShB@...il.com,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Add the missed ida_simple_remove() in
 ring_request_msix()

On Tue, Oct 13, 2020 at 10:45:18AM +0800, Jing Xiangfeng wrote:
> ring_request_msix() misses to call ida_simple_remove() in an error path.
> Add the missed function call to fix it.

...

>  	ring->irq = pci_irq_vector(ring->nhi->pdev, ring->vector);
> -	if (ring->irq < 0)
> +	if (ring->irq < 0) {
> +		ida_simple_remove(&nhi->msix_ida, ret);
>  		return ring->irq;
> +	}
>  
>  	irqflags = no_suspend ? IRQF_NO_SUSPEND : 0;
>  	return request_irq(ring->irq, ring_msix, irqflags, "thunderbolt", ring);

According to your logic don't you need it here as well?

-- 
With Best Regards,
Andy Shevchenko