linux-kernel - Re: [PATCH v6 66/80] locking/refcount: document the new "oldp" pointer value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201013124756.GT2611@hirez.programming.kicks-ass.net>
Date:   Tue, 13 Oct 2020 14:47:56 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Jann Horn <jannh@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 66/80] locking/refcount: document the new "oldp"
 pointer value

On Tue, Oct 13, 2020 at 01:54:21PM +0200, Mauro Carvalho Chehab wrote:
> Changeset a435b9a14356 ("locking/refcount: Provide __refcount API to obtain the old value")
> added a new parameter to most refcount functions, but didn't update
> the kernel-doc markups.

Mindless warning begets mindless patch :/ Please turn on brain while
operating the computer.

> Add a description for it on all touched functions.

It's actively wrong now, the function in the comment is the variant with
__ and they do not have the extra parameter.

> Fixes: a435b9a14356 ("locking/refcount: Provide __refcount API to obtain the old value")

Breaks actual sanity.