linux-kernel - Re: [GIT PULL] x86/platform updates for v5.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20e7f2da-793d-18f9-3345-45095383bdc6@hpe.com>
Date:   Tue, 13 Oct 2020 07:25:09 -0700
From:   Mike Travis <mike.travis@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     Linus Torvalds <torvalds@...ux-foundation.org>,
        x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Dimitri Sivanich <sivanich@....com>,
        "Wahl, Steve" <steve.wahl@....com>, Russ Anderson <rja@....com>
Subject: Re: [GIT PULL] x86/platform updates for v5.10



On 10/13/2020 6:37 AM, Mike Travis wrote:
> 
> 
> On 10/13/2020 6:29 AM, Borislav Petkov wrote:
>> On Tue, Oct 13, 2020 at 05:33:37AM -0700, Mike Travis wrote:
>>> I'm working on the correct code now, and I have UV4 & UV4A machine time
>>> starting at 7am (PDT) to test it.  The UV5 simulator does not yet 
>>> emulate
>>> console initiated NMI from the BMC.
>>
>> Ok, let me put it another way: is this simple fix good enough for now so
>> that it doesn't trigger the build error on Linus' tree or not? You can
>> take your time and do all kinds of fixing later but we need a minimal
>> fix *now*!
>>
>> Pretty please?
>>
> 
> Yes, it does fix the compile error.

Turns out I was combining 3 different sources to determine if the NMI 
INT occurred and I used the 1ULL << SHIFT to check each one.  So the 
MASK is indeed extraneous and can be removed.  Tested and patch follows.