linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab900e0f-fd5f-a1cc-8300-b681c97f7231@gmail.com>
Date:   Tue, 13 Oct 2020 17:29:08 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Fabien Parent <fparent@...libre.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>, linux-iio@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, pmeerw@...erw.net,
        lars@...afoo.de, knaack.h@....de, jic23@...nel.org
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node



On 13/10/2020 11:06, Fabien Parent wrote:
> Hi Matthias,
> 
>> Any reason you don't enable the status in the pumpkin dts?
> 
> No particular reasons. I looked at what other MTK SoC did for this IP,
> and half went with the status to be disabled and the other half went
> with an enabled status.  So I went the mt8183 way since it is the last
> MTK SoC to have been merged and disabled by default. If you think it
> is better to be enabled by default, I can change it, I don't have any
> strong opinion about this.
> 

Well on mt8183 it is missing the thermal driver although as you can read the 
values via sysfs I'd say to enable it. No need to resend just because of that. 
I'll take the patch as-is as soon as Jonathan takes 1/2.

Regards,
Matthias