linux-kernel - Re: disabling CONFIG_LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6fd1e91e-19d0-6682-dfc6-49f1cd60408b@infradead.org>
Date:   Tue, 13 Oct 2020 09:03:24 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Udo van den Heuvel <udovdh@...all.nl>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        Pavel Machek <pavel@....cz>
Subject: Re: disabling CONFIG_LED_CLASS

On 10/13/20 8:53 AM, Randy Dunlap wrote:
> [adding LED people + list]
> 
> On 10/13/20 6:24 AM, Udo van den Heuvel wrote:
>> L.S.,
>>
>> Even after removing all LED referneces from .config, a `make oldconfig`
>> leads to:
>>
>> *
>> * LED Support
>> *
>> LED Support (NEW_LEDS) [Y/?] (NEW) y
>>   LED Class Support (LEDS_CLASS) [M/y/?] (NEW) n
>>
>> Where 'n' is not a valid choice.
>> So why is this LED thing forced upon us and how do we get rid of it?
>>
>> Or else please explain how to make this work on a Gigabyte Technology
>> Co., Ltd. X570 AORUS PRO...
>>
>> Kind regards,
>> Udo
>>
>>
>> On 13-10-2020 11:24, Udo van den Heuvel wrote:
>>> Hello,
>>>
>>> While looking at the 5.9 kernel config I noticed there is no easy way to
>>> disable LED support in general.
>>> There's this NEW_LEDS thing that is not shown, etc.
>>> So I get:
>>>
>>> # make oldconfig
>>> scripts/kconfig/conf  --oldconfig Kconfig
>>> *
>>> * Restart config...
>>> *
>>> *
>>> * LED Support
>>> *
>>> LED Support (NEW_LEDS) [Y/?] (NEW) y
>>>   LED Class Support (LEDS_CLASS) [M/y/?] (NEW) n
>>>
>>> CONFIG_LEDS_CLASS:
>>>
>>> This option enables the LED sysfs class in /sys/class/leds.  You'll
>>> need this to do anything useful with LEDs.  If unsure, say N.
>>>
>>> Symbol: LEDS_CLASS [=m]
>>> Type  : tristate
>>> Defined at drivers/leds/Kconfig:17
>>>   Prompt: LED Class Support
>>>   Depends on: NEW_LEDS [=y]
>>>   Location:
>>>     -> Device Drivers
>>>       -> LED Support (NEW_LEDS [=y])
>>> Selected by [m]:
>>>   - SND_HDA_GENERIC [=m] && SOUND [=y] && !UML && SND [=m] && SND_HDA
>>> [=m] && SND_HDA_GENERIC_LEDS [=y]
>>> Selected by [n]:
>>>   - TS5500 [=n] && X86_32 [=n] && MELAN [=n]
>>>   - ADB_PMU_LED [=n] && MACINTOSH_DRIVERS [=n] && PPC_PMAC && ADB_PMU [=n]
>>>   - ATH5K [=n] && NETDEVICES [=y] && WLAN [=n] && WLAN_VENDOR_ATH [=n]
>>> && (PCI [=y] || ATH25) && MAC80211 [=n]
>>>   - ATH9K [=n] && NETDEVICES [=y] && WLAN [=n] && WLAN_VENDOR_ATH [=n]
>>> && MAC80211 [=n] && HAS_DMA [=y]
>>>   - ATH9K_HTC [=n] && NETDEVICES [=y] && WLAN [=n] && WLAN_VENDOR_ATH
>>> [=n] && USB [=y] && MAC80211 [=n]
>>>   - CARL9170_LEDS [=n] && NETDEVICES [=y] && WLAN [=n] &&
>>> WLAN_VENDOR_ATH [=n] && CARL9170 [=n]
>>>   - BRCMSMAC [=n] && NETDEVICES [=y] && WLAN [=n] &&
>>> WLAN_VENDOR_BROADCOM [=n] && MAC80211 [=n] && BCMA_POSSIBLE [=y] &&
>>> BCMA_DRIVER_GPIO [=n]
>>>   - IWLEGACY [=n] && NETDEVICES [=y] && WLAN [=n] && WLAN_VENDOR_INTEL [=n]
>>>   - INPUT_WISTRON_BTNS [=n] && !UML && INPUT [=y] && INPUT_MISC [=y] &&
>>> X86_32 [=n]
>>>   - SENSORS_APPLESMC [=n] && HWMON [=y] && INPUT [=y] && X86 [=y]
>>>   - IR_REDRAT3 [=n] && RC_DEVICES [=n] && USB_ARCH_HAS_HCD [=y] &&
>>> RC_CORE [=n]
>>>   - IR_WINBOND_CIR [=n] && RC_DEVICES [=n] && (X86 [=y] && PNP [=y] ||
>>> COMPILE_TEST [=n]) && RC_CORE [=n]
>>>   - IR_TTUSBIR [=n] && RC_DEVICES [=n] && USB_ARCH_HAS_HCD [=y] &&
>>> RC_CORE [=n]
>>>   - BACKLIGHT_ADP8860 [=n] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE
>>> [=y] && I2C [=y]
>>>   - BACKLIGHT_ADP8870 [=n] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE
>>> [=y] && I2C [=y]
>>>   - BACKLIGHT_LM3639 [=n] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE
>>> [=y] && I2C [=y]
>>>   - SND_USB_TONEPORT [=n] && SOUND [=y] && !UML && SND [=m] && SND_USB
>>> [=y] && USB [=y]
>>>   - HID_LENOVO [=n] && INPUT [=y] && HID [=y]
>>>   - HID_WACOM [=n] && INPUT [=y] && HID [=y] && USB_HID [=m]
>>>   - HUAWEI_WMI [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] &&
>>> ACPI_BATTERY [=n] && ACPI_WMI [=n] && INPUT [=y]
>>>   - ACER_WMI [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI [=y]
>>> && BACKLIGHT_CLASS_DEVICE [=y] && SERIO_I8042 [=y] && INPUT [=y] &&
>>> (RFKILL [=n] || RFKILL [=n]=n) && ACPI_WMI [=n]
>>>   - ASUS_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y] && (RFKILL [=n] ||
>>> RFKILL [=n]=n) && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)
>>>   - ASUS_WIRELESS [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && INPUT [=y]
>>>   - ASUS_WMI [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI_WMI
>>> [=n] && ACPI_BATTERY [=n] && INPUT [=y] && HWMON [=y] &&
>>> BACKLIGHT_CLASS_DEVICE [=y] && (RFKILL [=n] || RFKILL [=n]=n) &&
>>> HOTPLUG_PCI [=n] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)
>>>   - EEEPC_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n) && (ACPI_VIDEO [=n]
>>> || ACPI_VIDEO [=n]=n) && HOTPLUG_PCI [=n] && BACKLIGHT_CLASS_DEVICE [=y]
>>>   - DELL_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && DMI
>>> [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO
>>> [=n]=n) && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y] &&
>>> DELL_SMBIOS [=n]
>>>   - FUJITSU_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] ||
>>> ACPI_VIDEO [=n]=n)
>>>   - HP_ACCEL [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && INPUT [=y]
>>> && ACPI [=y] && SERIO_I8042 [=y]
>>>   - THINKPAD_ACPI [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && ACPI_BATTERY [=n] && INPUT [=y] && (RFKILL [=n] || RFKILL
>>> [=n]=n) && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n) &&
>>> BACKLIGHT_CLASS_DEVICE [=y]
>>>   - SAMSUNG_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] &&
>>> (RFKILL [=n] || RFKILL [=n]=n) && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)
>>> && BACKLIGHT_CLASS_DEVICE [=y]
>>>   - ACPI_TOSHIBA [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && ACPI_WMI [=n] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y] &&
>>> (SERIO_I8042 [=y] || SERIO_I8042 [=y]=n) && (ACPI_VIDEO [=n] ||
>>> ACPI_VIDEO [=n]=n) && (RFKILL [=n] || RFKILL [=n]=n) && IIO [=n]
>>>   - LG_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI [=y]
>>> && ACPI_WMI [=n] && INPUT [=y]
>>>   - SYSTEM76_ACPI [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI [=y]
>>>   - TOPSTAR_LAPTOP [=n] && X86 [=y] && X86_PLATFORM_DEVICES [=n] && ACPI
>>> [=y] && INPUT [=y]
>>>
>>>
>>> And there is no 'n' option. None of the devices as dependencies (on the
>>> left) are enabled.
>>> SND_HDA_GENERIC_LEDS is automagically enabled and disabling it via vi is
>>> no option.
>>> So how do I disable this stuff?
>>>
>>> Kind regards,
>>> Udo

Hi,

I was able to disable LEDS_CLASS and NEW_LEDS after I disabled the following
config symbols:


--- xx64/config-def64	2020-10-13 08:53:56.050501724 -0700
+++ xx64/.config	2020-10-13 08:58:12.439205389 -0700
-CONFIG_MAC80211_LEDS=y
-CONFIG_RFKILL_LEDS=y
-# CONFIG_LED_TRIGGER_PHY is not set
-CONFIG_INPUT_LEDS=y
-# CONFIG_HID_LED is not set
-# CONFIG_USB_LED_TRIG is not set
-# CONFIG_USB_LEDS_TRIGGER_USBPORT is not set
-CONFIG_LEDS_TRIGGERS=y
-CONFIG_EEEPC_LAPTOP=y
+# CONFIG_EEEPC_LAPTOP is not set

This last one was the biggest problem for me.
I started with x86_64 defconfig.


-- 
~Randy