linux-kernel - RE: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Oct 2020 11:18:19 -0700
From:   Alex Qiu <xqiu@...gle.com>
To:     Grant Peltier <grant.peltier.jg@...esas.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Adam Vaughn <adam.vaughn.xh@...esas.com>,
        Guenter Roeck <groeck7@...il.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Jason Ling <jasonling@...gle.com>
Subject: RE: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1
 telemetry for RAA228228

(Intercepting the email thread...)

Hi Grant,

Looks like you made a typo in your patch:

> + case raa_dmpvr2_2rail_nontc:
> + info->func[0] &= ~PMBUS_HAVE_TEMP;
> + info->func[1] &= ~PMBUS_HAVE_TEMP;
> + fallthrough;

Did you mean "/* fallthrough */" instead of "fallthrough;"?

- Alex Qiu