linux-kernel - Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e325e4f-bb7c-f2d3-1f16-34a89397df39@roeck-us.net>
Date:   Tue, 13 Oct 2020 11:37:54 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alex Qiu <xqiu@...gle.com>,
        Grant Peltier <grant.peltier.jg@...esas.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Adam Vaughn <adam.vaughn.xh@...esas.com>,
        Guenter Roeck <groeck7@...il.com>
Cc:     Jason Ling <jasonling@...gle.com>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1
 telemetry for RAA228228

On 10/13/20 11:18 AM, Alex Qiu wrote:
> (Intercepting the email thread...)
> 
> Hi Grant,
> 
> Looks like you made a typo in your patch:
> 
>> + case raa_dmpvr2_2rail_nontc:
>> + info->func[0] &= ~PMBUS_HAVE_TEMP;
>> + info->func[1] &= ~PMBUS_HAVE_TEMP;
>> + fallthrough;
> 
> Did you mean "/* fallthrough */" instead of "fallthrough;"?
> 

No, that is the fancy new way to indicate fallthrough in the kernel.
It is converted to either
	__attribute__((__fallthrough__))
or to
	do {} while (0)
in include/linux/compiler_attributes.h.

Guenter