linux-kernel - Re: [PATCH] qla2xxx: Do not consume srb greedily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160262862432.3018.12930536900869421478.b4-ty@oracle.com>
Date:   Tue, 13 Oct 2020 18:42:47 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Arun Easi <aeasi@...vell.com>, Daniel Wagner <dwagner@...e.de>,
        Nilesh Javali <njavali@...vell.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] qla2xxx: Do not consume srb greedily

On Tue, 29 Sep 2020 09:38:02 +0200, Daniel Wagner wrote:

> qla2xx_process_get_sp_from_handle() will clear the slot which the
> current srb is stored. So this function has a side effect. Therefore,
> we can't use it in qla24xx_process_mbx_iocb_response() to check
> for consistency and later again in qla24xx_mbx_iocb_entry().
> 
> Let's move the consistency check directly into
> qla24xx_mbx_iocb_entry() and avoid the double call or any open coding
> of the qla2xx_process_get_sp_from_handle() functionality.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Do not consume srb greedily
      https://git.kernel.org/mkp/scsi/c/657ed8a8a61b

-- 
Martin K. Petersen	Oracle Linux Engineering