linux-kernel - Re: [PATCH v5 1/2] PCI/ERR: Call pci_bus_reset() before calling ->slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014000327.GA94232@otc-nc-03>
Date:   Tue, 13 Oct 2020 17:03:28 -0700
From:   "Raj, Ashok" <ashok.raj@...el.com>
To:     Kuppuswamy Sathyanarayanan <sathyanarayanan.nkuppuswamy@...il.com>
Cc:     bhelgaas@...gle.com, okaya@...nel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        sathyanarayanan.kuppuswamy@...ux.intel.com,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH v5 1/2] PCI/ERR: Call pci_bus_reset() before calling
 ->slot_reset() callback

On Tue, Oct 13, 2020 at 04:45:01PM -0700, Kuppuswamy Sathyanarayanan wrote:
> Currently if report_error_detected() or report_mmio_enabled()
> functions requests PCI_ERS_RESULT_NEED_RESET, current
> pcie_do_recovery() implementation does not do the requested
> explicit device reset, but instead just calls the
> report_slot_reset() on all affected devices. Notifying about the
> reset via report_slot_reset() without doing the actual device
> reset is incorrect. So call pci_bus_reset() before triggering
> ->slot_reset() callback.
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> Reviewed-by: Sinan Kaya <okaya@...nel.org>
> ---
>  Changes since v4:
>   * Added check for pci_reset_bus() return value.

Looks good!

Reviewed-by: Ashok Raj <ashok.raj@...el.com>