linux-kernel - Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014061732.GA3672@kozik-lap>
Date:   Wed, 14 Oct 2020 08:17:32 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Tomasz Figa <tomasz.figa@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver

On Tue, Oct 13, 2020 at 07:43:40PM -0700, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2020-10-01 09:56:46)
> > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
> > index 34ccb1d23bc3..68af082d4716 100644
> > --- a/drivers/clk/samsung/clk-exynos-clkout.c
> > +++ b/drivers/clk/samsung/clk-exynos-clkout.c
> > @@ -28,41 +31,103 @@ struct exynos_clkout {
> [...]
> > +       if (!match) {
> > +               dev_err(dev, "cannot match parent device\n");
> > +               return -EINVAL;
> > +       }
> > +       variant = match->data;
> > +
> > +       *mux_mask = variant->mux_mask;
> > +       dev_err(dev, "MATCH: %x\n", variant->mux_mask);
> 
> Is this a debug print?

Debugging left over, thanks for catching this. I'll remove it.

Best regards,
Krzysztof