linux-kernel - Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Oct 2020 09:06:31 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     Nilesh Javali <njavali@...vell.com>, Arun Easi <aeasi@...vell.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion

Hi Finn,

On Wed, Oct 14, 2020 at 11:57:04AM +1100, Finn Thain wrote:
> 
> On Tue, 13 Oct 2020, Daniel Wagner wrote:
> > How so? I am struggling to see how it could be a change in behavior. But 
> > then I sometimes fail at simple logic ;)
> > 
> 
> Me too, so I confirmed the result by executing the code snippets.

Thanks for taking the time to explain it to me!

> I don't know whether the changes in v3 are desirable or not, I was just 
> pointing out that the commit log ("valid qpair but the firmware has not 
> yet started return EBUSY") now seems to disagree with the code.

I see where I did my thinko. In v3 we have more ENODEV due to the fact
that we test the pointers first (qpair, fpcort). If either of them is
invalid we get the ENODEV. Actually, it's makes more sense and is likely
to be 'more correct'.

Anyway, let me update the commit log.

Thanks a lot!
Daniel