linux-kernel - Re: [PATCH 0/2] module: some refactoring in module_sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6fd4ba1-b431-afd8-1800-3a8f4b74f30e@omprussia.ru>
Date:   Wed, 14 Oct 2020 11:18:39 +0300
From:   Sergey Shtylyov <s.shtylyov@...russia.ru>
To:     Joe Perches <joe@...ches.com>, Jessica Yu <jeyu@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] module: some refactoring in module_sig_check()

Hello!

On 14.10.2020 1:44, Joe Perches wrote:

>> Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo.
>> I'm doing some little refactoring in module_sig_check()...
>>
>> [1/2] module: merge repetitive strings in module_sig_check()
>> [2/2] module: unindent comments in module_sig_check()
> 
> I think this code is rather cryptic and could be made clearer.
> 
> How about:
> ---
>   kernel/module.c | 51 ++++++++++++++++++++++++++-------------------------
>   1 file changed, 26 insertions(+), 25 deletions(-)

    Looks good. Do you want to post complete patch(es)? :-)

[...]

MBR, Sergei