linux-kernel - Re: [PATCH] kbuild: doc: describe proper script invocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Oct 2020 06:43:06 +0200 (CEST)
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ujjwal Kumar <ujjwalkumar0501@...il.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] kbuild: doc: describe proper script invocation



On Wed, 14 Oct 2020, Masahiro Yamada wrote:

> On Tue, Oct 13, 2020 at 11:31 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > On Thu, Oct 1, 2020 at 4:57 PM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
> > >
> > > During an investigation to fix up the execute bits of scripts in the kernel
> > > repository, Andrew Morton and Kees Cook pointed out that the execute bit
> > > should not matter, and that build scripts cannot rely on that. Kees could
> > > not point to any documentation, though.
> > >
> > > Masahiro Yamada explained the convention of setting execute bits to make it
> > > easier for manual script invocation.
> > >
> > > Provide some basic documentation how the build shall invoke scripts, such
> > > that the execute bits do not matter, and acknowledge that execute bits
> > > are useful nonetheless.
> > >
> > > This serves as reference for further clean-up patches in the future.
> > >
> > > Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
> > > Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
> > > Link: https://lore.kernel.org/linux-kbuild/CAK7LNAQdrvMkDA6ApDJCGr+5db8SiPo=G+p8EiOvnnGvEN80gA@mail.gmail.com/
> > >
> > > Suggested-by: Andrew Morton <akpm@...ux-foundation.org>
> > > Suggested-by: Kees Cook <keescook@...omium.org>
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> >
> >
> > Applied to linux-kbuild.
> > Thanks.
> >
> 
> No, not really.
> 
> I will re-think if this is the right thing to do.
> 
>

Masahiro-san, Andrew Morton has already picked this patch in his branch; 
so, if we do not shout loudly, it will be merged. And we can follow up 
with a solid improvement for rc2.

I am happy to rework the documentation and help guide and review the 
follow-up patches that have been sent by Ujjwal.

Please provide some specific feedback what is wrong and why; I think the 
basic request not to rely on the execute bit from Andrew and Kees is still 
valid. Maybe we just need to be more specific on the rules to follow in 
Makefiles and have multiple examples for the different cases to consider.

Thanks,

Lukas