linux-kernel - Re: [RFC] openprom: Fix 'opiocnextprop'; ensure integer conversions; use string size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1329005-fa37-e02e-0105-2634ee566f55@infradead.org>
Date:   Tue, 13 Oct 2020 23:40:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Michael Witten <mfwitten@...il.com>, sparclinux@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC] openprom: Fix 'opiocnextprop'; ensure integer conversions;
 use string size

Hi,

On 9/4/20 12:40 PM, Michael Witten wrote:
> The following patch improves the quality and correctness of the openprom code.
> 
> 
> --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
> 
> ---
>   arch/sparc/include/asm/prom.h   |   2 +-
>   arch/sparc/kernel/prom_common.c |  14 +--
>   drivers/sbus/char/openprom.c    | 263 ++++++++++++++++++++++++++++------------
>   3 files changed, 194 insertions(+), 85 deletions(-)
> 
> diff --git a/drivers/sbus/char/openprom.c b/drivers/sbus/char/openprom.c
> index 30b9751aad30..9bc2877aa09a 100644
> --- a/drivers/sbus/char/openprom.c
> +++ b/drivers/sbus/char/openprom.c
>   	/* If the bufsize is too large, just limit it.
>   	 * Fix from Jason Rappleye.
>   	 */

The sparc cross-compiler that I am using does not like to see type
casting in preprocessor lines.
SIZE_MAX is #defined as (~(size_t)0) and for the #if line below,

> +	#if OPROMMAXPARAM > SIZE_MAX/2
> +		if (bufsize > SIZE_MAX/2)
> +			return -EFAULT;
> +	#endif

gcc (cpp) says:

In file included from ../drivers/sbus/char/openprom.c:19:
../include/linux/limits.h:9:21: warning: "size_t" is not defined, 
evaluates to 0 [-Wundef]
     9 | #define SIZE_MAX (~(size_t)0)
       |                     ^~~~~~
../drivers/sbus/char/openprom.c:95:22: note: in expansion of macro 
'SIZE_MAX'
    95 |  #if OPROMMAXPARAM > SIZE_MAX/2
       |                      ^~~~~~~~
../include/linux/limits.h:9:28: error: missing binary operator before 
token "0"
     9 | #define SIZE_MAX (~(size_t)0)
       |                            ^
../drivers/sbus/char/openprom.c:95:22: note: in expansion of macro 
'SIZE_MAX'
    95 |  #if OPROMMAXPARAM > SIZE_MAX/2
       |                      ^~~~~~~~

causing a build error.

--
~Randy