linux-kernel - Re: FW: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAD=hENeBf=u30XWnZFdcZCYGR2Q41HhCFRSduRER=k05zqaCzQ@mail.gmail.com>
Date:   Wed, 14 Oct 2020 08:37:28 +0800
From:   Zhu Yanjun <zyjzyj2000@...il.com>
To:     Yanjun Zhu <yanjunz@...dia.com>,
        Alex Dewar <alex.dewar90@...il.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Bob Pearson <rpearsonhpe@...il.com>,
        linux-rdma@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: FW: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference

On Wed, Oct 14, 2020 at 8:34 AM Yanjun Zhu <yanjunz@...dia.com> wrote:
>
>
>
> -----Original Message-----
> From: Alex Dewar <alex.dewar90@...il.com>
> Sent: Tuesday, October 13, 2020 12:53 AM
> Cc: Alex Dewar <alex.dewar90@...il.com>; Yanjun Zhu <yanjunz@...dia.com>; Doug Ledford <dledford@...hat.com>; Jason Gunthorpe <jgg@...pe.ca>; Bob Pearson <rpearsonhpe@...il.com>; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference
>
> skb_clone() is called without checking if the returned pointer is NULL before it is dereferenced. Fix by adding an additional error check.
>
> Fixes: e7ec96fc7932 ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")
> Addresses-Coverity-ID: 1497804: Null pointer dereferences (NULL_RETURNS)
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>

Thanks a lot.

Zhu Yanjun
> ---
>  drivers/infiniband/sw/rxe/rxe_recv.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
> index 11f3daf20768..a65936e12f89 100644
> --- a/drivers/infiniband/sw/rxe/rxe_recv.c
> +++ b/drivers/infiniband/sw/rxe/rxe_recv.c
> @@ -266,10 +266,13 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
>                 /* for all but the last qp create a new clone of the
>                  * skb and pass to the qp.
>                  */
> -               if (mce->qp_list.next != &mcg->qp_list)
> +               if (mce->qp_list.next != &mcg->qp_list) {
>                         per_qp_skb = skb_clone(skb, GFP_ATOMIC);
> -               else
> +                       if (!per_qp_skb)
> +                               goto err2;
> +               } else {
>                         per_qp_skb = skb;
> +               }
>
>                 per_qp_pkt = SKB_TO_PKT(per_qp_skb);
>                 per_qp_pkt->qp = qp;
> @@ -283,6 +286,10 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
>
>         return;
>
> +err2:
> +       spin_unlock_bh(&mcg->mcg_lock);
> +       rxe_drop_ref(mcg);      /* drop ref from rxe_pool_get_key. */
> +
>  err1:
>         kfree_skb(skb);
>  }
> --
> 2.28.0
>