| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Oct 2020 12:29:53 +0200
From: Jacopo Mondi <jacopo@...ndi.org>
To: Niklas Söderlund <niklas.soderlund@...natech.se>
Cc: Jacopo Mondi <jacopo+renesas@...ndi.org>,
linux-renesas-soc@...r.kernel.org, geert+renesas@...der.be,
laurent.pinchart@...asonboard.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: r8a779a0: Add VIN nodes
Hi Niklas,
On Wed, Oct 14, 2020 at 12:19:50PM +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your work.
>
> On 2020-10-14 11:44:43 +0200, Jacopo Mondi wrote:
> > Add VIN nodes to R8A779A0 R-Car V3U SoC.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> > ---
> > arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 320 ++++++++++++++++++++++
> > 1 file changed, 320 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > index 83962ad30a1d..bc81e6a761d3 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > @@ -105,6 +105,326 @@ scif0: serial@...60000 {
> > status = "disabled";
> > };
> >
> > + vin0: video@...f0000 {
> > + compatible = "renesas,vin-r8a779a0";
>
> How is this tested? There is no driver support and the schema you added
Compile tested as specified in the cover letter
> the compat string to mandates the 'renesas,id' property for the vin
I was sure 'renesas,id' was BSP stuff 0_0
> nodes. As far as I can tell the reason for this id is gone with the new
> pipeline of the V3U. So I guess as long as we don't break dtschema
> validation all is good, just wanted to make sure ;-)
>
Do you think we should limit adding CPG clock entries only ?
> > + reg = <0 0xe6ef0000 0 0x1000>;
> > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 730>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 730>;
> > + status = "disabled";
> > + };
> > +
> > + vin1: video@...f1000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef1000 0 0x1000>;
> > + interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 731>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 731>;
> > + status = "disabled";
> > + };
> > +
> > + vin2: video@...f2000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef2000 0 0x1000>;
> > + interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 800>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 800>;
> > + status = "disabled";
> > + };
> > +
> > + vin3: video@...f3000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef3000 0 0x1000>;
> > + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 801>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 801>;
> > + status = "disabled";
> > + };
> > +
> > + vin4: video@...f4000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef4000 0 0x1000>;
> > + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 802>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 802>;
> > + status = "disabled";
> > + };
> > +
> > + vin5: video@...f5000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef5000 0 0x1000>;
> > + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 803>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 803>;
> > + status = "disabled";
> > + };
> > +
> > + vin6: video@...f6000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef6000 0 0x1000>;
> > + interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 804>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 804>;
> > + status = "disabled";
> > + };
> > +
> > + vin7: video@...f7000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef7000 0 0x1000>;
> > + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 805>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 805>;
> > + status = "disabled";
> > + };
> > +
> > + vin8: video@...f8000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef8000 0 0x1000>;
> > + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 806>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 806>;
> > + status = "disabled";
> > + };
> > +
> > + vin9: video@...f9000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ef9000 0 0x1000>;
> > + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 807>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 807>;
> > + status = "disabled";
> > + };
> > +
> > + vin10: video@...fa000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6efa000 0 0x1000>;
> > + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 808>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 808>;
> > + status = "disabled";
> > + };
> > +
> > + vin11: video@...fb000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6efb000 0 0x1000>;
> > + interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 809>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 809>;
> > + status = "disabled";
> > + };
> > +
> > + vin12: video@...fc000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6efc000 0 0x1000>;
> > + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 810>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 810>;
> > + status = "disabled";
> > + };
> > +
> > + vin13: video@...fd000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6efd000 0 0x1000>;
> > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 811>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 811>;
> > + status = "disabled";
> > + };
> > +
> > + vin14: video@...fe000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6efe000 0 0x1000>;
> > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 812>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 812>;
> > + status = "disabled";
> > + };
> > +
> > + vin15: video@...ff000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6eff000 0 0x1000>;
> > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 813>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 813>;
> > + status = "disabled";
> > + };
> > +
> > + vin16: video@...d0000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed0000 0 0x1000>;
> > + interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 814>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 814>;
> > + status = "disabled";
> > + };
> > +
> > + vin17: video@...d1000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed1000 0 0x1000>;
> > + interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 815>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 815>;
> > + status = "disabled";
> > + };
> > +
> > + vin18: video@...d2000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed2000 0 0x1000>;
> > + interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 816>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 816>;
> > + status = "disabled";
> > + };
> > +
> > + vin19: video@...d3000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed3000 0 0x1000>;
> > + interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 817>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 817>;
> > + status = "disabled";
> > + };
> > +
> > + vin20: video@...d4000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed4000 0 0x1000>;
> > + interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 818>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 818>;
> > + status = "disabled";
> > + };
> > +
> > + vin21: video@...d5000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed5000 0 0x1000>;
> > + interrupts = <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 819>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 819>;
> > + status = "disabled";
> > + };
> > +
> > + vin22: video@...d6000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed6000 0 0x1000>;
> > + interrupts = <GIC_SPI 182 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 820>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 820>;
> > + status = "disabled";
> > + };
> > +
> > + vin23: video@...d7000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed7000 0 0x1000>;
> > + interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 821>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 821>;
> > + status = "disabled";
> > + };
> > +
> > + vin24: video@...d8000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed8000 0 0x1000>;
> > + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 822>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 822>;
> > + status = "disabled";
> > + };
> > +
> > + vin25: video@...d9000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ed9000 0 0x1000>;
> > + interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 823>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 823>;
> > + status = "disabled";
> > + };
> > +
> > + vin26: video@...da000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6eda000 0 0x1000>;
> > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 824>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 824>;
> > + status = "disabled";
> > + };
> > +
> > + vin27: video@...db000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6edb000 0 0x1000>;
> > + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 825>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 825>;
> > + status = "disabled";
> > + };
> > +
> > + vin28: video@...dc000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6edc000 0 0x1000>;
> > + interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 826>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 826>;
> > + status = "disabled";
> > + };
> > +
> > + vin29: video@...dd000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6edd000 0 0x1000>;
> > + interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 827>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 827>;
> > + status = "disabled";
> > + };
> > +
> > + vin30: video@...de000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6ede000 0 0x1000>;
> > + interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 828>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 828>;
> > + status = "disabled";
> > + };
> > +
> > + vin31: video@...df000 {
> > + compatible = "renesas,vin-r8a779a0";
> > + reg = <0 0xe6edf000 0 0x1000>;
> > + interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 829>;
> > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > + resets = <&cpg 829>;
> > + status = "disabled";
> > + };
> > +
> > csi40: csi2@...a0000 {
> > compatible = "renesas,r8a779a0-csi2";
> > reg = <0 0xfeaa0000 0 0x10000>;
> > --
> > 2.28.0
> >
>
> --
> Regards,
> Niklas Söderlund
Powered by blists - more mailing lists