linux-kernel - RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Oct 2020 11:05:13 +0000
From:   <Michael.Wu@...ics.com>
To:     <jarkko.nikula@...ux.intel.com>,
        <andriy.shevchenko@...ux.intel.com>,
        <mika.westerberg@...ux.intel.com>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <morgan.chang@...ics.com>, <dean.hsiao@...ics.com>,
        <paul.chen@...ics.com>
Subject: RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

On 10/14/20 6:53 PM, jarkko.nikula@...ux.intel.com wrote:
> Thanks for the patch. I was thinking this too after your report but
> haven't found actually time to look at implementing it.
> 
> But what I was thinking it is probably good to have two patches. First
> patch that changes only i2c_dw_read_clear_intrbits_slave() semantics so
> that it's called only once like here and second patch that does other
> logic changes. Makes easier to catch possible regressions I think.
> 
> Jarkko

I can't agree with you more.
I'll separate them into two patches in next version.

By the way, I found a way to compile my patch by myself via
	"make multi_v7_defconfig"
and
	"make drivers/i2c/busses/i2c-designware-slave.o".

I've done and there were no warnings about
drivers/i2c/busses/i2c-designware-slave.c:13.
--
Michael Wu