lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Oct 2020 08:32:19 -0500 From: Rob Herring <robh@...nel.org> To: Serge Semin <Sergey.Semin@...kalelectronics.ru> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Andy Gross <agross@...nel.org>, linux-kernel@...r.kernel.org, Neil Armstrong <narmstrong@...libre.com>, linux-usb@...r.kernel.org, linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, Bjorn Andersson <bjorn.andersson@...aro.org>, Rob Herring <robh+dt@...nel.org>, Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kevin Hilman <khilman@...libre.com>, Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>, Serge Semin <fancer.lancer@...il.com>, Felipe Balbi <balbi@...nel.org>, Roger Quadros <rogerq@...com>, linux-arm-kernel@...ts.infradead.org, Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Mathias Nyman <mathias.nyman@...el.com>, linux-snps-arc@...ts.infradead.org, Manu Gautam <mgautam@...eaurora.org>, devicetree@...r.kernel.org Subject: Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru> > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > --- > .../devicetree/bindings/usb/dwc3.txt | 125 -------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 295 ++++++++++++++++++ > 2 files changed, 295 insertions(+), 125 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:44:4: [warning] wrong indentation: expected 4 but found 3 (indentation) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: dwc3@...0000: $nodename:0: 'dwc3@...0000' does not match '^usb(@.*)?' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dt.yaml: usb@...00000: snps,quirk-frame-length-adjustment: True is not of type 'array' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml See https://patchwork.ozlabs.org/patch/1382003 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
Powered by blists - more mailing lists