linux-kernel - Re: [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014134152.GA1560405@bogus>
Date:   Wed, 14 Oct 2020 08:41:52 -0500
From:   Rob Herring <robh@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Mark Brown <broonie@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Benson Leung <bleung@...omium.org>,
        Dan Murphy <dmurphy@...com>, Pavel Machek <pavel@....cz>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        devicetree <devicetree@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        linux-leds <linux-leds@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lubomir Rintel <lkundrak@...sk>
Subject: Re: [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require
 #address-cells=<0> for slave mode

On Wed, 14 Oct 2020 00:08:42 +0800, Zhen Lei wrote:
> scripts/dtc/checks.c:
> if (get_property(node, "spi-slave"))
> 	spi_addr_cells = 0;
> if (node_addr_cells(node) != spi_addr_cells)
> 	FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
> if (node_size_cells(node) != 0)
> 	FAIL(c, dti, node, "incorrect #size-cells for SPI bus");
> 
> The above code in check_spi_bus_bridge() require that the number of address
> cells must be 0. So we should explicitly declare "#address-cells = <0>".
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---
>  .../devicetree/bindings/spi/spi-controller.yaml      | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)
> 

Applied, thanks!

Note that I tried fixing this in dtc, but that was rejected. So this 
gets the schema in sync with dtc.

Rob