linux-kernel - Re: [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Oct 2020 08:50:19 -0500
From:   Rob Herring <robh@...nel.org>
To:     "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
Cc:     Dan Murphy <dmurphy@...com>, Pavel Machek <pavel@....cz>,
        linux-leds <linux-leds@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Lubomir Rintel <lkundrak@...sk>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] dt-bindings: misc: correct the property name
 cmd-gpios to cmd-gpio

On Wed, Oct 14, 2020 at 09:29:26AM +0800, Leizhen (ThunderTown) wrote:
> 
> 
> On 2020/10/14 1:32, Dan Murphy wrote:
> > Zhen
> > 
> > On 10/13/20 11:08 AM, Zhen Lei wrote:
> >> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is
> >> cmd-gpio.
> >>
> >> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235:
> >> cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
> >>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> >> ---
> >>   Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++---
> >>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> >> index b3c45c046ba5e37..c7a06a9650db2ed 100644
> >> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> >> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> >> @@ -24,7 +24,7 @@ properties:
> >>     compatible:
> >>       const: olpc,xo1.75-ec
> >>   -  cmd-gpios:
> >> +  cmd-gpio:
> > 
> > Preference is gpios not gpio. But Rob H accept or reject
> 
> Look at the search result below. It seems that the driver have not been merged into mainline.

Yes, in drivers/platform/olpc/olpc-xo175-ec.c.

Your mistake is the gpiod api takes just 'cmd' as the GPIO core handles 
both forms.

> But the property name is really used as cmd-gpio at mmp2-olpc-xo-1-75.dts:235, I don't think
> the mmp2-olpc-xo-1-75.dts can make a mistake. Otherwise, the driver will not work properly.
> Meanwhile, Both names cmd-gpios and cmd-gpio seem to be in use. But I prefer cmd-gpio, after
> all, only one gpio is assigned now. The motorola,cmd-gpios add "s" because it contains 3 gpio.

The preference is it is always '-gpios' just like it's always 
'interrupts' or 'clocks'.

However, whether to change this is really up to the OLPC folks. Given 
the driver has always supported both forms, it should be okay to change 
the dts. Though there could be other users besides the kernel.

Rob