linux-kernel - Re: [PATCH] KVM: VMX: eVMCS: make evmcs_sanitize_exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Oct 2020 22:01:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     kbuild-all@...ts.01.org,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Yang Weijiang <weijiang.yang@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: VMX: eVMCS: make evmcs_sanitize_exec_ctrls() work
 again

Hi Vitaly,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on vhost/linux-next linus/master linux/master v5.9 next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vitaly-Kuznetsov/KVM-VMX-eVMCS-make-evmcs_sanitize_exec_ctrls-work-again/20201014-180828
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-randconfig-r015-20201014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d17b759596aa18f05176cee4695968b88977f6a4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vitaly-Kuznetsov/KVM-VMX-eVMCS-make-evmcs_sanitize_exec_ctrls-work-again/20201014-180828
        git checkout d17b759596aa18f05176cee4695968b88977f6a4
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/x86/kvm/vmx/vmx.c: In function 'setup_vmcs_config':
>> arch/x86/kvm/vmx/vmx.c:2595:6: error: 'enlightened_vmcs' undeclared (first use in this function); did you mean 'hv_enlightened_vmcs'?
    2595 |  if (enlightened_vmcs)
         |      ^~~~~~~~~~~~~~~~
         |      hv_enlightened_vmcs
   arch/x86/kvm/vmx/vmx.c:2595:6: note: each undeclared identifier is reported only once for each function it appears in

vim +2595 arch/x86/kvm/vmx/vmx.c

  2578	
  2579		/* Require Write-Back (WB) memory type for VMCS accesses. */
  2580		if (((vmx_msr_high >> 18) & 15) != 6)
  2581			return -EIO;
  2582	
  2583		vmcs_conf->size = vmx_msr_high & 0x1fff;
  2584		vmcs_conf->order = get_order(vmcs_conf->size);
  2585		vmcs_conf->basic_cap = vmx_msr_high & ~0x1fff;
  2586	
  2587		vmcs_conf->revision_id = vmx_msr_low;
  2588	
  2589		vmcs_conf->pin_based_exec_ctrl = _pin_based_exec_control;
  2590		vmcs_conf->cpu_based_exec_ctrl = _cpu_based_exec_control;
  2591		vmcs_conf->cpu_based_2nd_exec_ctrl = _cpu_based_2nd_exec_control;
  2592		vmcs_conf->vmexit_ctrl         = _vmexit_control;
  2593		vmcs_conf->vmentry_ctrl        = _vmentry_control;
  2594	
> 2595		if (enlightened_vmcs)
  2596			evmcs_sanitize_exec_ctrls(vmcs_conf);
  2597	
  2598		return 0;
  2599	}
  2600	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (39827 bytes)