lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <fa656cc7-a323-7013-8435-915a1f8b5866@linuxfoundation.org> Date: Wed, 14 Oct 2020 09:45:49 -0600 From: Shuah Khan <skhan@...uxfoundation.org> To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org> Cc: Peter Zijlstra <peterz@...radead.org>, "Ahmed S. Darwish" <a.darwish@...utronix.de>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, Thomas Winischhofer <thomas@...ischhofer.net>, Johan Hovold <johan@...nel.org>, Mathias Nyman <mathias.nyman@...el.com>, Alan Stern <stern@...land.harvard.edu>, linux-omap@...r.kernel.org, Kukjin Kim <kgene@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, Felipe Balbi <balbi@...nel.org>, Duncan Sands <duncan.sands@...e.fr>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [patch 07/12] usbip: Remove in_interrupt() check On 10/14/20 8:52 AM, Thomas Gleixner wrote: > From: Ahmed S. Darwish <a.darwish@...utronix.de> > > The usage of in_interrupt() in drivers is phased out and Linus clearly > requested that code which changes behaviour depending on context should > either be separated or the context be conveyed in an argument passed by the > caller, which usually knows the context. > > usbip_recv() uses in_interrupt() to conditionally print context information > for debugging messages. The value is zero as the function is only called > from various *_rx_loop() kthread functions. Remove it. > > Signed-off-by: Ahmed S. Darwish <a.darwish@...utronix.de> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de> > Cc: Valentina Manea <valentina.manea.m@...il.com> > Cc: Shuah Khan <shuah@...nel.org> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: linux-usb@...r.kernel.org > > --- > drivers/usb/usbip/usbip_common.c | 5 ----- > 1 file changed, 5 deletions(-) > > --- a/drivers/usb/usbip/usbip_common.c > +++ b/drivers/usb/usbip/usbip_common.c > @@ -324,11 +324,6 @@ int usbip_recv(struct socket *sock, void > } while (msg_data_left(&msg)); > > if (usbip_dbg_flag_xmit) { > - if (!in_interrupt()) > - pr_debug("%-10s:", current->comm); > - else > - pr_debug("interrupt :"); > - > pr_debug("receiving....\n"); > usbip_dump_buffer(buf, size); > pr_debug("received, osize %d ret %d size %zd total %d\n", > > Looks good to me. Acked-by: Shuah Khan <skhan@...uxfoundation.org> thanks, -- Shuah
Powered by blists - more mailing lists